Repository navigation
Name the exported PDF after the site and reporting period - #13765
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the PDF export filename generation logic to use localized date ranges and site hosts instead of slugified strings. It moves the getSiteHost utility to a shared location, updates PDFExportOrchestrator and PDFHeader to use the new implementation, and adds comprehensive test coverage. Feedback was provided to add a defensive fallback for Intl.DateTimeFormat.prototype.formatRange to prevent runtime errors in older browsers that do not support this ES2021 API.
|
Size Change: 0 B Total Size: 3.39 MB ℹ️ View Unchanged
|
zutigrm
requested changes
Oct 5, 2026
zutigrm
left a comment
zutigrm
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @mehidi258 nice work. I left you some comments, let me know what you think
Collaborator
Author
Thanks @zutigrm for the feedbacks, i have addressed all. Passing to you for verify. |
Collaborator
|
Thanks @mehidi, there are some merge conflicts that need ti be resolved |
Collaborator
Author
zutigrm
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s):
Relevant technical choices
Intl.DateTimeFormat.prototype.formatRangein the codebase, sopdf-utils.tsadds/// <reference lib="es2021.intl" />—tsconfigtargetses5, which leaves it untyped. All@wordpress/browserslist-configtargets support it.getSiteHostgained an optionalfallbackparameter, so the filename can fall back toreportfor an unparseable URL while the header keeps showing the raw value as before./lose the separators, e.g. zh-CN2026/3/1 – 2026/3/7becomes202631 – 202637.PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist
🤖 Generated with Claude Code