-
Notifications
You must be signed in to change notification settings - Fork 336
Closed
Labels
P0High priorityHigh priorityTeam MIssues for Squad 2Issues for Squad 2Type: BugSomething isn't workingSomething isn't working
Description
Bug Description
While testing #11820, I noticed the following:
- Whenever we click on the 'Feature tour' at the menu, there are 4 black radius borders that appear in the user menu.
- This doesn't appear for other menu items. Maybe we should look into it.
Steps to reproduce
- Set up Site Kit with setupFlowRefresh enabled
- Click the "Start a feature tour" button in the Help menu and notice the black radius borders
Screenshots
Additional Context
- PHP Version:
- OS: [e.g. iOS]
- Browser: [e.g. chrome, safari]
- Plugin Version: [e.g. 22]
- Device: [e.g. iPhone6]
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
- When the "Start a feature tour" item in the Help menu is clicked, it should not display black radius borders.
- The styling for the menu item should be consistent with the others.
Implementation Brief
- In
assets/sass/components/global/_googlesitekit-help-menu.scss- For
.googlesitekit-cta-linkadd a rule, if the element isbutton,outlineshould benone.
- For
Test Coverage
Not required.
QA Brief
- Follow the steps to reproduce above
- Ensure that clicking on the "Start a feature tour" button in the help menu does not cause a black outline to appear
Changelog entry
- Fix styling for the "Start a feature tour" help menu item.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P0High priorityHigh priorityTeam MIssues for Squad 2Issues for Squad 2Type: BugSomething isn't workingSomething isn't working