-
Notifications
You must be signed in to change notification settings - Fork 328
Closed
Labels
P0High priorityHigh priorityTeam MIssues for Squad 2Issues for Squad 2Type: EnhancementImprovement of an existing featureImprovement of an existing feature
Description
Feature Description
As discussed here in Figma, buttons in the new design should match those in the rest of the plugin.
This issue is to remove the font family override in the styling for the Sign in with Google button on the SFR splash screen, reverting to Google Sans Text.
site-kit-wp/assets/sass/components/setup/_googlesitekit-splash.scss
Lines 151 to 153 in 9d59b4c
| .googlesitekit-start-setup-wrap .mdc-button__label { | |
| font-family: $f-secondary; | |
| } |
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
- The Sign in with Google button on the SFR splash screen should have the font family Google Sans Text.
Implementation Brief
- Remove this SCSS block:
site-kit-wp/assets/sass/components/setup/_googlesitekit-splash.scss
Lines 151 to 153 in 9d59b4c
| .googlesitekit-start-setup-wrap .mdc-button__label { | |
| font-family: $f-secondary; | |
| } |
Test Coverage
- Fix any failing tests.
QA Brief
- Set up Site Kit with
setupFlowRefreshfeature flag - In the setup screen, ensure the
Sign in with Googlebutton has the font familyGoogle Sans Textinstead ofGoogle Sans Display
Changelog entry
- Fix the font family for the "Sign in with Google" button on the new splash screen.
Metadata
Metadata
Assignees
Labels
P0High priorityHigh priorityTeam MIssues for Squad 2Issues for Squad 2Type: EnhancementImprovement of an existing featureImprovement of an existing feature