-
Notifications
You must be signed in to change notification settings - Fork 328
Closed
Labels
P0High priorityHigh priorityTeam MIssues for Squad 2Issues for Squad 2Type: EnhancementImprovement of an existing featureImprovement of an existing feature
Description
Feature Description
When Analytics is set up after the initial setup flow, via the the Connect More Services screen or a setup CTA, the Analytics setup success notification should be displayed when returning to the dashboard.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
- Given that the Analytics module setup is initiated after the initial setup flow, via the the Connect More Services screen or a setup CTA:
- The Analytics setup success notification is displayed when the user lands on the dashboard from the Key Metrics setup screen.
- The Analytics setup success notification should not be shown when landing on the dashboard from the initial setup flow.
Implementation Brief
-
To determine if the Analytics setup is initiated from the initial setup flow, use the
getQueryArgfunction to determine if the current URL includes theshowProgressquery argument. -
Use the
useFeaturehook to determine if thesetupFlowRefreshfeature flag is enabled.
- In
assets/js/components/key-metrics-setup/KeyMetricsSetupApp.js- Create a new boolean variable,
isInitialSetupFlow, which should betrueif thesetupFlowRefreshfeature flag is enabled and the module setup is initiated from the initial setup flow. - If the
isInitialSetupFlowisfalse, add the following query params to the dashboard url.notification: Value should beauthentication_successslug: It would beanalytics-4
- Create a new boolean variable,
Test coverage
- Add a test to check the navigation URL when the submission happens on non-initial setup mode.
QA Brief
- Install and activate the
Site Kit by Google Staging Proxyplugin. - Enable the
setupFlowRefreshfeature. - Set up the Site Kit plugin, but do not set up the Analytics module.
- Go to the dashboard after connecting Site Kit, and set up the Analytics module from Settings.
- Once the Key Metrics is set up and the
Complete setupCTA is clicked, you will be redirected to the dashboard. Ensure that the URL contains the following query parameters:
| Parameter | Value |
|---|---|
| notification | authentication_success |
| slug | analytics-4 |
Changelog entry
- Ensure the Analytics setup success notification is shown when Analytics is set up after the new initial setup flow.
Metadata
Metadata
Assignees
Labels
P0High priorityHigh priorityTeam MIssues for Squad 2Issues for Squad 2Type: EnhancementImprovement of an existing featureImprovement of an existing feature