Support 3.8 with tests fix #263
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks 🙏 |
Contributor
Author
|
Done 🙂 Build status: https://travis-ci.org/github/uburuntu/python-fire |
Contributor
Author
|
Now with pytype 🙃 Build status: https://travis-ci.org/github/uburuntu/python-fire |
ssbarnea
approved these changes
Jun 7, 2020
|
This is going to show us how fast the project is going to adapt. Based on #139 which is almost two years old, I would say that a lot. I am keeping an eye on Fire but I will avoid it for the moment on my own projects. |
Collaborator
Collaborator
|
Merged in 457b156 |
CherylMoonba
added a commit
to CherylMoonba/devices
that referenced
this pull request
Jul 20, 2025
- Enables Travis for 3.8 - Fixes namedtuple test for 3.8 COPYBARA_INTEGRATE_REVIEW=google/python-fire#263 from uburuntu:master efaf65fe5b0986121f0e1b76a949a07169dd354f PiperOrigin-RevId: 316134191 Change-Id: I5e3ef20b488fa917b81525d5936a8e147b0458e1
KurtMuelle
added a commit
to KurtMuelle/obtained
that referenced
this pull request
Jul 22, 2025
- Enables Travis for 3.8 - Fixes namedtuple test for 3.8 COPYBARA_INTEGRATE_REVIEW=google/python-fire#263 from uburuntu:master efaf65fe5b0986121f0e1b76a949a07169dd354f PiperOrigin-RevId: 316134191 Change-Id: I5e3ef20b488fa917b81525d5936a8e147b0458e1
hwlegends
pushed a commit
to hwlegends/python-fire
that referenced
this pull request
Aug 20, 2025
- Enables Travis for 3.8 - Fixes namedtuple test for 3.8 COPYBARA_INTEGRATE_REVIEW=google/python-fire#263 from uburuntu:master efaf65fe5b0986121f0e1b76a949a07169dd354f PiperOrigin-RevId: 316134191 Change-Id: I5e3ef20b488fa917b81525d5936a8e147b0458e1
marsMerge2021
added a commit
to marsMerge2021/NTPMeasures
that referenced
this pull request
Aug 31, 2025
- Enables Travis for 3.8 - Fixes namedtuple test for 3.8 COPYBARA_INTEGRATE_REVIEW=google/python-fire#263 from uburuntu:master efaf65fe5b0986121f0e1b76a949a07169dd354f PiperOrigin-RevId: 316134191 Change-Id: I5e3ef20b488fa917b81525d5936a8e147b0458e1
Hernandez19891
added a commit
to Hernandez19891/Illumina
that referenced
this pull request
Sep 15, 2025
- Enables Travis for 3.8 - Fixes namedtuple test for 3.8 COPYBARA_INTEGRATE_REVIEW=google/python-fire#263 from uburuntu:master efaf65fe5b0986121f0e1b76a949a07169dd354f PiperOrigin-RevId: 316134191 Change-Id: I5e3ef20b488fa917b81525d5936a8e147b0458e1
1278827
added a commit
to 1278827/Hardware
that referenced
this pull request
Sep 23, 2025
- Enables Travis for 3.8 - Fixes namedtuple test for 3.8 COPYBARA_INTEGRATE_REVIEW=google/python-fire#263 from uburuntu:master efaf65fe5b0986121f0e1b76a949a07169dd354f PiperOrigin-RevId: 316134191 Change-Id: I5e3ef20b488fa917b81525d5936a8e147b0458e1
VLLanguage
added a commit
to VLLanguage/VLLanguage
that referenced
this pull request
Nov 23, 2025
- Enables Travis for 3.8 - Fixes namedtuple test for 3.8 COPYBARA_INTEGRATE_REVIEW=google/python-fire#263 from uburuntu:master efaf65fe5b0986121f0e1b76a949a07169dd354f PiperOrigin-RevId: 316134191 Change-Id: I5e3ef20b488fa917b81525d5936a8e147b0458e1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I want to use Fire in project with Python 3.8, so I think library should be officially supported for 3.8.
I added travis run for 3.8 and one test
testInitRequiresFlagSyntaxSubclassNamedTuplegot failed: link.Investigation showed that now namedtuple attributes of type
collections._tuplegettersince 3.8, notproperty: link, commit:So I added backward compatibility check in
MemberVisiblefunction.One not solved trouble: pytype does not support 3.8 (google/pytype#587) -- https://travis-ci.org/github/uburuntu/python-fire, but I can add check in
travis.ymlto skip it currently.