Exposes builtin functions from the standard library #193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes builtin functions from the standard library to fire and fixes #187.
Previously, certain builtin functions from the standard library (e.g.
math.sin) would raise a TypeError complaining about getting one less required argument than they need. The original diagnosis was that these functions were written in C and did not expose their signature toinspect.getfullargspecorinspect.signature. Howevermath.sindoes expose its signature to these inspect functions:The problem was that
fire.inspectutils._GetArgSpecInfowas incorrectly skipping the first argument of these builtins under the assumption that a non-null__self__attribute of a builtin always means that the function is a method and its first argument isself. However, for builtin functions in standard libraries, the__self__attribute is the module it came from. The proposed fix is to only skip the first argument of builtins if the__self__attribute isn't a module.