Completion Enhancements #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This is great, thanks for the PR! I'll take a closer look after the weekend. |
Collaborator
|
Apologies for the delay; I haven't had a chance to look in detail at this yet. |
Contributor
Author
|
No worries 😄 In the meantime, I could also have a look at #148 and resolve it in the same PR. |
Collaborator
|
That would be awesome :) |
Collaborator
|
Heads up some of the tests are failing in Python 3.6 |
Contributor
Author
Fixed them now. All tests passing! |
Collaborator
|
I apologize I messed up with the merge. |
Collaborator
…r option Fix google#136 for Bash
After a function is entered as a subcommand, the completion shows both function args and module flags. But if a module flag is entered following a function or its args, the function args are no longer shown in completion suggestion.
…ompletion script code
dbieber
force-pushed
the
master
branch
2 times, most recently
from
6c35e82 to
8bf2314
Compare
Collaborator
|
merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This PR changes the completion scripts that are generated by running the
--completionoption for the Fire generated commands. The changes are aimed to give more flexibility to the user.Main Changes
startbased completion tolast-commandbased completion.startbased completion, the entire string that has been entered into the command prompt so far is used to map the completion suggestions. This creates inflexibility for the user, causing completion can not tab hint and complete the second param? #136.last-commandbased completion, suggestions are based on the last command/subcommand (non-option arg) entered by the user. This gives flexibility to the user, to be able to use options in any order, thereby fixing completion can not tab hint and complete the second param? #136.Features
The features added are:
bash&fish