fix: Error matching built-in providers if specified by name rather than inferred from model.#331
Open
telackey wants to merge 4 commits intogoogle:mainfrom
Open
fix: Error matching built-in providers if specified by name rather than inferred from model.#331telackey wants to merge 4 commits intogoogle:mainfrom
telackey wants to merge 4 commits intogoogle:mainfrom
Conversation
…ather than inferred by model.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
5 tasks
|
No linked issues found. Please link an issue in your pull request description or title. Per our Contributing Guidelines, all PRs must:
You can also use cross-repo references like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #335
Description
This fixes an error where specifying a built-in provider by name when using ModelConfig would fail, because
router.resolve_provider(config.provider)without first callingproviders.load_builtins_once(), which was only called when the provider was being inferred.The actual fix here is tiny, which is to lift the load_builtins_once/load_plugins_once calls outside the if/then. Since the loading is done only once, the impact should be insignificant.
Before:
How Has This Been Tested?
Manually and new unit test added.
Checklist: