Repository navigation
Add tests demonstrating unclosed Javadoc inline tags leaving comments unformatted. - #1509
Merged
Merged
Conversation
… unformatted.
In classic Javadoc comments, an unclosed inline tag outside `<pre>`
(for example, an unclosed `{@link ...` lacking a closing `}`) causes lexing
to fail with a `LexException` in `checkMatchingTags()`. Because
`JavadocFormatter` catches `LexException` and returns the input string
unmodified, the comment is left completely unformatted.
Add tests reproducing this behavior with unclosed inline tags before
subsequent list items, blank lines, footer tags, and at the end of the comment.
PiperOrigin-RevId: 1009630980
copybara-service
Bot
force-pushed
the
test_994306859
branch
from
October 29, 2026 13:05
521befb to
93bb96d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests demonstrating unclosed Javadoc inline tags leaving comments unformatted.
In classic Javadoc comments, an unclosed inline tag outside
<pre>(for example, an unclosed
{@link ...lacking a closing}) causes lexingto fail with a
LexExceptionincheckMatchingTags(). BecauseJavadocFormattercatchesLexExceptionand returns the input stringunmodified, the comment is left completely unformatted.
Add tests reproducing this behavior with unclosed inline tags before
subsequent list items, blank lines, footer tags, and at the end of the comment.