Fix #1132 Load services outside of constructors and class initializers#1142
Merged
copybara-service[bot] merged 1 commit intomasterfrom Aug 21, 2024
Merged
Fix #1132 Load services outside of constructors and class initializers#1142copybara-service[bot] merged 1 commit intomasterfrom
copybara-service[bot] merged 1 commit intomasterfrom
Conversation
Fixes the error on startup by loading the service when needed and not when the class is initializing. IntelliJ docs on this, https://plugins.jetbrains.com/docs/intellij/plugin-services.html#retrieving-a-service. Tested locally with IntelliJ versions 2021.3 and 2024.2. #1134 has bug #1132 tagged, but I don't think it does anything to resolve the issue in it's current state. (I do agree that getting on the newer IntelliJ tooling is beneficial though, it offers inspections that catches issues like this.) Fixes #1132. Fixes #1138 COPYBARA_INTEGRATE_REVIEW=#1138 from nrayburn-tech:fix/1132 5866980 PiperOrigin-RevId: 665876052
copybara-service
bot
force-pushed
the
test_665849974
branch
from
e7306c1 to
ac46c75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1132 Load services outside of constructors and class initializers
Fixes the error on startup by loading the service when needed and not when the class is initializing. IntelliJ docs on this, https://plugins.jetbrains.com/docs/intellij/plugin-services.html#retrieving-a-service.
Tested locally with IntelliJ versions 2021.3 and 2024.2.
#1134 has bug #1132 tagged, but I don't think it does anything to resolve the issue in it's current state. (I do agree that getting on the newer IntelliJ tooling is beneficial though, it offers inspections that catches issues like this.)
Fixes #1132.
Fixes #1138
FUTURE_COPYBARA_INTEGRATE_REVIEW=#1138 from nrayburn-tech:fix/1132 5866980