Fix #1132 Load services outside of constructors and class initializers#1138
Closed
nrayburn-tech wants to merge 1 commit intogoogle:masterfrom
Closed
Fix #1132 Load services outside of constructors and class initializers#1138nrayburn-tech wants to merge 1 commit intogoogle:masterfrom
nrayburn-tech wants to merge 1 commit intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
Author
|
CLA signed. |
Collaborator
|
@nrayburn-tech I think the CLA check is failing because the email address in the commit doesn't match the email address the CLA was signed with, could you rebase the commits with the correct email address? |
Contributor
Author
Collaborator
|
Thanks, the CLA results were stale, I re-ran it and it passed. |
plumpy
approved these changes
Aug 21, 2024
Collaborator
|
Thanks for the PR, I appreciate the help! |
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
Fixes the error on startup by loading the service when needed and not when the class is initializing. IntelliJ docs on this, https://plugins.jetbrains.com/docs/intellij/plugin-services.html#retrieving-a-service. Tested locally with IntelliJ versions 2021.3 and 2024.2. #1134 has bug #1132 tagged, but I don't think it does anything to resolve the issue in it's current state. (I do agree that getting on the newer IntelliJ tooling is beneficial though, it offers inspections that catches issues like this.) Fixes #1132. Fixes #1138 FUTURE_COPYBARA_INTEGRATE_REVIEW=#1138 from nrayburn-tech:fix/1132 5866980 PiperOrigin-RevId: 665849974
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the error on startup by loading the service when needed and not when the class is initializing. IntelliJ docs on this, https://plugins.jetbrains.com/docs/intellij/plugin-services.html#retrieving-a-service.
Tested locally with IntelliJ versions 2021.3 and 2024.2.
#1134 has bug #1132 tagged, but I don't think it does anything to resolve the issue in it's current state. (I do agree that getting on the newer IntelliJ tooling is beneficial though, it offers inspections that catches issues like this.)
Fixes #1132.