feat: Add organization artifact metadata APIs#3944
Conversation
gmlewis
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3944 +/- ##
==========================================
+ Coverage 93.50% 93.52% +0.01%
==========================================
Files 206 207 +1
Lines 17550 17600 +50
==========================================
+ Hits 16411 16461 +50
Misses 938 938
Partials 201 201 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@gmlewis Sir can you please review the code? |
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @maishivamhoo123, @alexandear , and @Not-Dhananjay-Mishra!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
cc: @stevehipwell - @zyfy29
…github final changes
|
@Not-Dhananjay-Mishra can you please check once i think the latest pr is able to meet all your requirements? |
gmlewis
added
the
Breaking API Change
gmlewis
changed the title
gmlewis
changed the title
gmlewis
removed
the
Breaking API Change
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @maishivamhoo123!
All new tests need to add a call to testBadOptions to improve code coverage. Please search the repo for examples using testBadOptions and do likewise.
Co-authored-by: Dhananjay Mishra <technicaldmcontact@gmail.com>
Co-authored-by: Dhananjay Mishra <technicaldmcontact@gmail.com>
Co-authored-by: Dhananjay Mishra <technicaldmcontact@gmail.com>
Co-authored-by: Dhananjay Mishra <technicaldmcontact@gmail.com>
|
@alexandear , @Not-Dhananjay-Mishra , @gmlewis can you please review the changes , I made all the suggested changes . |
|
@maishivamhoo123 - it looks to me like you addressed all the review feedback... (thank you!), but just to be sure, let's let @alexandear respond, and then we will merge. |
|
@alexandear Sir Thank you Sir for your review I made all the suggested changes can you please check ? |
|
Thank you, @alexandear! |
|
@alexandear, @gmlewis, @Not-Dhananjay-Mishra Thank you very much for all the reviews and feedback. I truly learned a lot while working on this issue. I’m looking forward to contributing more and learning from your experience. Thanks again! |
4 participants
Description
This PR implements the Organization Artifact Metadata APIs as requested in #3917.
This version corrects the scope from Repository to Organization level.
Changes
github/orgs_artifacts.go.POST /orgs/{org}/artifacts/metadata/deployment-recordPOST /orgs/{org}/artifacts/metadata/deployment-record/cluster/{cluster}POST /orgs/{org}/artifacts/metadata/storage-recordGET /orgs/{org}/artifacts/{subject_digest}/metadata/deployment-recordsGET /orgs/{org}/artifacts/{subject_digest}/metadata/storage-recordsgithub/orgs_artifacts_test.go.github-accessors.goandgithub-stringify_test.goviascript/generate.sh.Checklist
script/test.sh).script/lint.sh).script/generate.sh.Fixes #3917