feat: Add secret scanning push protection pattern configurations API#3672
Merged
gmlewis merged 12 commits intogoogle:masterfrom Aug 13, 2025
Merged
feat: Add secret scanning push protection pattern configurations API#3672gmlewis merged 12 commits intogoogle:masterfrom
gmlewis merged 12 commits intogoogle:masterfrom
Conversation
Contributor
|
Please see #3667 (review) |
dmclink
changed the title
dmclink
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3672 +/- ##
==========================================
- Coverage 91.23% 91.02% -0.21%
==========================================
Files 185 186 +1
Lines 16421 16473 +52
==========================================
+ Hits 14982 14995 +13
- Misses 1254 1293 +39
Partials 185 185 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
requested changes
Aug 12, 2025
| CustomPatternSettings []*SecretScanningCustomPatternSetting `json:"custom_pattern_settings,omitempty"` | ||
| } | ||
|
|
||
| type SecretScanningProviderPatternSetting struct { |
Collaborator
There was a problem hiding this comment.
Please add a godoc-style comment for every exported struct.
gmlewis
approved these changes
Aug 12, 2025
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @dmclink!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
@alexandear or @stevehipwell - might one of you have time for a code review? Thank you!
Collaborator
|
Thank you, @stevehipwell! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for newly announced API endpoints
Closes #3661