Document upcoming changes to events payload#3667
Conversation
feat: Add deprecation notices for AuthorAssociation field in various event types
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3667 +/- ##
=======================================
Coverage 91.23% 91.23%
=======================================
Files 185 185
Lines 16421 16421
=======================================
Hits 14982 14982
Misses 1254 1254
Partials 185 185 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
changed the title
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @romanywu!
LGTM.
Awaiting second LGTM+Approval from any other contributor before merging.
@alexandear or @stevehipwell - might one of you be available for a code review? Thank you!
alexandear
left a comment
alexandear
left a comment
There was a problem hiding this comment.
Please remove (Issue #3665) from PR's title and add Closes #3665 to description.
stevehipwell
left a comment
stevehipwell
left a comment
There was a problem hiding this comment.
Thanks @romanywu this looks really good, just waiting on the PR changes @alexandear asked for before I approve.
@gmlewis if you want to get this merged you should be able to update the title and PR body.
roman-y-wu
changed the title
✅ |
|
Thank you, @romanywu, @alexandear, and @stevehipwell! |
4 participants
Closes #3665