refactor: Fix gocritic.paramTypeCombine lint issues#3655
Merged
gmlewis merged 1 commit intogoogle:masterfrom Jul 28, 2025
Merged
refactor: Fix gocritic.paramTypeCombine lint issues#3655gmlewis merged 1 commit intogoogle:masterfrom
gmlewis merged 1 commit intogoogle:masterfrom
Conversation
alexandear
force-pushed
the
refactor/param-type-combine
branch
2 times, most recently
from
292556e to
3e2e68c
Compare
alexandear
force-pushed
the
refactor/param-type-combine
branch
from
3e2e68c to
c77318b
Compare
gmlewis
approved these changes
Jul 28, 2025
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @alexandear!
LGTM.
Merging.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3655 +/- ##
=======================================
Coverage 91.25% 91.25%
=======================================
Files 184 184
Lines 16311 16311
=======================================
Hits 14884 14884
Misses 1245 1245
Partials 182 182 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR combines function parameters by type (with the help of gocritic.paramTypeCombine). See #3654 (comment)