refactor!: Change GitService methods to pass required params by-value instead of by-ref#3654
Merged
gmlewis merged 1 commit intogoogle:masterfrom Aug 4, 2025
Conversation
gmlewis
changed the title
Collaborator
|
Please follow step 4 in CONTRIBUTING.md and push the changes to this PR. |
rupokghosh
force-pushed
the
rupok/change-pointer-params-to-values
branch
from
d124f0e to
826440e
Compare
Contributor
Author
|
done ✔️ @gmlewis |
alexandear
reviewed
Jul 28, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3654 +/- ##
==========================================
- Coverage 91.25% 91.20% -0.05%
==========================================
Files 185 185
Lines 16378 16360 -18
==========================================
- Hits 14945 14921 -24
- Misses 1249 1254 +5
- Partials 184 185 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alexandear
reviewed
Jul 28, 2025
gmlewis
added
the
Breaking API Change
gmlewis
changed the title
rupokghosh
force-pushed
the
rupok/change-pointer-params-to-values
branch
2 times, most recently
from
64a09b4 to
d813b23
Compare
gmlewis
approved these changes
Aug 2, 2025
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @rupokghosh!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Contributor
|
Please extend the PR header to mention that only |
gmlewis
changed the title
GitService endpoints to pass required params by-value instead of by-ref
Collaborator
|
@alexandear - how's that? |
gmlewis
changed the title
GitService endpoints to pass required params by-value instead of by-refGitService methods to pass required params by-value instead of by-ref
Collaborator
|
Whups, I think "methods" is better than "endpoints", agreed? |
alexandear
suggested changes
Aug 4, 2025
rupokghosh
force-pushed
the
rupok/change-pointer-params-to-values
branch
from
d813b23 to
939e78a
Compare
alexandear
approved these changes
Aug 4, 2025
update exmaples change to using values refactor(git)!: improve CreateRef API with value types and exported struct format new updateref struct remove backwards compatibility create tag in git tags slfhg
rupokghosh
force-pushed
the
rupok/change-pointer-params-to-values
branch
from
939e78a to
92a65bb
Compare
Contributor
Author
|
let me know if we can merge this in now! |
gmlewis
approved these changes
Aug 4, 2025
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @rupokghosh and @alexandear!
LGTM.
Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
GitServicemethods now pass required params by-value instead of by-ref.What problem are you solving?
Notes
This is most likely going to be a multi PR issue, since this is my first time working on this codebase. I started by picking a "service" area ( Git ) and converted each function that I thought met the criteria set in the issue mentioned, which are: