Add Social Accounts API by Pedja-Djape · Pull Request #3647 · google/go-github

Pedja-Djape · 2025-07-24T21:21:34Z

This pull request aims to implement the API for social accounts mentioned in Issue-3634

Fixes: #3634.

codecov · 2025-07-25T02:04:27Z

Codecov Report

❌ Patch coverage is 88.23529% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.24%. Comparing base (d1d6f45) to head (f3b7477).
⚠️ Report is 6 commits behind head on master.

Files with missing lines	Patch %	Lines
github/users_social_accounts.go	88.23%	4 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3647      +/-   ##
==========================================
- Coverage   91.25%   91.24%   -0.01%     
==========================================
  Files         184      185       +1     
  Lines       16311    16362      +51     
==========================================
+ Hits        14884    14929      +45     
- Misses       1245     1249       +4     
- Partials      182      184       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gmlewis

Thank you, @Pedja-Djape.
I realize this is in Draft mode, but wanted to give you some guidance before you finish the PR by writing unit tests.

example/social_accounts/main.go

github/users_social_accounts.go

example/social_accounts/main.go

github/users_social_accounts.go

…]string instead of []*strin

gmlewis · 2025-07-28T13:33:01Z

Please switch this from "Draft" to "Ready for review" when you are ready, @Pedja-Djape. Thank you!

Pedja-Djape · 2025-07-28T13:41:10Z

Please switch this from "Draft" to "Ready for review" when you are ready, @Pedja-Djape. Thank you!

Done! Thank you for all the help :)

gmlewis · 2025-07-28T13:55:39Z

example/social_accounts/main.go

+	accounts, err := fetchSocialAccounts(username)
+	if err != nil {
+		log.Fatalf("Error: %v\n", err)
+		return


You can delete this line. The nice thing about log.Fatalf is that it immediately kills the program, so the return is not necessary.

Also, please be sure to run gofmt on this file after you edit it.

Ah, I didn't know about that log.Fatalf behavior, nice. Thanks for the heads up

alexandear · 2025-07-28T14:04:08Z

example/social_accounts/main.go

I suggest moving this example to examples_test.go, since it looks quite straightforward:

func ExampleUsersService_ListUserSocialAccounts() { client := github.NewClient(nil) users, _, err := client.Users.ListUserSocialAccounts(context.Background(), username, &github.ListOptions{}) if err != nil { log.Fatalf("Failed to list user social accounts: %v", err) } // ... }

See

go-github/github/examples_test.go

Lines 96 to 112 in a8401a5

func ExampleUsersService_ListAll() {

client := github.NewClient(nil)

opts := &github.UserListOptions{}

for {

ctx := context.Background()

users, _, err := client.Users.ListAll(ctx, opts)

if err != nil {

log.Fatalf("error listing users: %v", err)

}

if len(users) == 0 {

break

}

opts.Since = *users[len(users)-1].ID

// Process users...

}

}

Hi @alexandear thanks for the review. Just want to clarify something before making changes: Are you saying that I should add the test in the examples_test.go file and remove this file? Or add the test in examples_test.go file and keep this file?

I should add the test in the examples_test.go file and remove this file

This is what I mean.

Awesome thanks!

alexandear · 2025-07-28T14:06:54Z

github/users_social_accounts.go

+// GitHub API docs: https://docs.github.com/rest/users/social-accounts#add-social-accounts-for-the-authenticated-user
+//
+//meta:operation POST /user/social_accounts
+func (s *UsersService) AddSocialAccounts(ctx context.Context, accountURLsToAdd []string) ([]*SocialAccount, *Response, error) {


Let's simplify naming:

Suggested change

func (s *UsersService) AddSocialAccounts(ctx context.Context, accountURLsToAdd []string) ([]*SocialAccount, *Response, error) {

func (s *UsersService) AddSocialAccounts(ctx context.Context, accountURLs []string) ([]*SocialAccount, *Response, error) {

alexandear · 2025-07-28T14:07:08Z

github/users_social_accounts.go

+		return nil, nil, err
+	}
+
+	var addedAccounts []*SocialAccount


Let's simplify:

Suggested change

var addedAccounts []*SocialAccount

var accounts []*SocialAccount

alexandear · 2025-07-28T14:07:52Z

github/users_social_accounts.go

+// GitHub API docs: https://docs.github.com/rest/users/social-accounts#delete-social-accounts-for-the-authenticated-user
+//
+//meta:operation DELETE /user/social_accounts
+func (s *UsersService) DeleteSocialAccounts(ctx context.Context, accountsToDelete []string) (*Response, error) {


For consistency with CreateSocialAccounts:

Suggested change

func (s *UsersService) DeleteSocialAccounts(ctx context.Context, accountsToDelete []string) (*Response, error) {

func (s *UsersService) DeleteSocialAccounts(ctx context.Context, accountURLs []string) (*Response, error) {

gmlewis

Thank you, @Pedja-Djape!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

gmlewis · 2025-07-29T18:11:10Z

Whups, sorry, it looks like there are some linter errors that need addressing first. Please take a look at these and push the necessary changes, @Pedja-Djape.

Pedja-Djape · 2025-07-29T18:38:58Z

Whups, sorry, it looks like there are some linter errors that need addressing first. Please take a look at these and push the necessary changes, @Pedja-Djape.

Hey @gmlewis it seems like the lint job isn't failing because of lint errors but rather due to a 429 error here:

validating openapi_operations.yaml
unexpected status code: 429 Too Many Requests
failed validating openapi_operations.yaml

EDIT: NVM!

Pedja-Djape · 2025-07-29T18:47:28Z

Whups, sorry, it looks like there are some linter errors that need addressing first. Please take a look at these and push the necessary changes, @Pedja-Djape.

Hey @gmlewis I noticed the lint job isn't failing becuse of lint issues but rather due to a

Whups, sorry, it looks like there are some linter errors that need addressing first. Please take a look at these and push the necessary changes, @Pedja-Djape.

Hey @gmlewis it seems like the lint job isn't failing because of lint errors but rather due to a 429 error here:
validating openapi_operations.yaml
unexpected status code: 429 Too Many Requests
failed validating openapi_operations.yaml
EDIT: NVM!

Actually @gmlewis I confirmed my openapi_operations.yaml is up-to-date with what's in prod ... I don't see a way for me to re-run the job, can we rerun this somehow? I ran all the scripts locally and see no issues.

gmlewis · 2025-07-29T19:15:59Z

Thank you, @Pedja-Djape and @alexandear!
Merging.

Issue-3634: Api For Social Accounts with example

e27d415

Pedja-Djape marked this pull request as draft July 24, 2025 21:24

Pedja-Djape changed the title ~~Issue-3634: Api For Social Accounts with example~~ Issue-3634: Api For Social Accounts Jul 24, 2025

gmlewis changed the title ~~Issue-3634: Api For Social Accounts~~ Add Social Accounts API Jul 25, 2025

gmlewis reviewed Jul 25, 2025

View reviewed changes

Pedja-Djape added 9 commits July 25, 2025 13:27

added first test for fetching social accounts for a user

a5ac195

updated copyright year

5f88c62

updated name for urls input variable

f05afd0

fixed DeleteSocialAccounts accountsToDelete input var to be of type […

623cf13

…]string instead of []*strin

added tests for AddSocialAccounts

7b7c227

added test for deleting social accounts

72f0e67

added test for ListUserSocialAccounts

3698ea2

formatted and linted code corrections

e987f88

ran generate.sh

7c026d1

Pedja-Djape added 2 commits July 28, 2025 09:34

corrected copyright year

43c91e2

applied comments for log formatting

3f5d1b7

Pedja-Djape marked this pull request as ready for review July 28, 2025 13:39

gmlewis added the NeedsReview PR is awaiting a review before merging. label Jul 28, 2025

gmlewis reviewed Jul 28, 2025

View reviewed changes

Pedja-Djape added 2 commits July 28, 2025 10:00

corrected lintting issues

a8401a5

removed return after log.Fatalf

928f56b

alexandear reviewed Jul 28, 2025

View reviewed changes

Pedja-Djape added 2 commits July 28, 2025 10:24

updated variable names

c056e96

moved ListUserSocialAccounts example to examples_test.go

f3b7477

Pedja-Djape requested review from alexandear and gmlewis July 29, 2025 17:46

gmlewis approved these changes Jul 29, 2025

View reviewed changes

alexandear approved these changes Jul 29, 2025

View reviewed changes

gmlewis removed the NeedsReview PR is awaiting a review before merging. label Jul 29, 2025

gmlewis merged commit d93435a into google:master Jul 29, 2025
5 of 8 checks passed

gmlewis mentioned this pull request Sep 22, 2025

Bump version of go-github to v75.0.0 #3723

Merged

	func ExampleUsersService_ListAll() {
	client := github.NewClient(nil)
	opts := &github.UserListOptions{}
	for {
	ctx := context.Background()
	users, _, err := client.Users.ListAll(ctx, opts)
	if err != nil {
	log.Fatalf("error listing users: %v", err)
	}
	if len(users) == 0 {
	break
	}
	opts.Since = *users[len(users)-1].ID
	// Process users...
	}
	}

	func (s UsersService) AddSocialAccounts(ctx context.Context, accountURLsToAdd []string) ([]SocialAccount, *Response, error) {
	func (s UsersService) AddSocialAccounts(ctx context.Context, accountURLs []string) ([]SocialAccount, *Response, error) {

	var addedAccounts []*SocialAccount
	var accounts []*SocialAccount

	func (s UsersService) DeleteSocialAccounts(ctx context.Context, accountsToDelete []string) (Response, error) {
	func (s UsersService) DeleteSocialAccounts(ctx context.Context, accountURLs []string) (Response, error) {

Conversation

Pedja-Djape commented Jul 24, 2025 • edited by gmlewis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gmlewis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gmlewis commented Jul 28, 2025

Uh oh!

Pedja-Djape commented Jul 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gmlewis left a comment

Choose a reason for hiding this comment

Uh oh!

gmlewis commented Jul 29, 2025

Uh oh!

Pedja-Djape commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Pedja-Djape commented Jul 29, 2025

Uh oh!

gmlewis commented Jul 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Pedja-Djape commented Jul 24, 2025 •

edited by gmlewis

Loading

codecov bot commented Jul 25, 2025 •

edited

Loading

Pedja-Djape commented Jul 29, 2025 •

edited

Loading