fix: Add validation for nil inputs in various services#3636
Merged
gmlewis merged 1 commit intogoogle:masterfrom Jul 24, 2025
Merged
fix: Add validation for nil inputs in various services#3636gmlewis merged 1 commit intogoogle:masterfrom
gmlewis merged 1 commit intogoogle:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3636 +/- ##
==========================================
- Coverage 91.33% 91.26% -0.08%
==========================================
Files 184 184
Lines 16174 16309 +135
==========================================
+ Hits 14773 14884 +111
- Misses 1227 1243 +16
- Partials 174 182 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
reviewed
Jul 23, 2025
gmlewis
approved these changes
Jul 24, 2025
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @alexandear!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
@stevehipwell - might you have time for a code review? Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
nilchecks to avoid nil pointer dereference and for consistency with other places:go-github/github/git_commits.go
Lines 130 to 132 in 8dacfa5
go-github/github/pulls.go
Lines 359 to 361 in 8dacfa5
go-github/github/enterprise_manage_ghes_config.go
Lines 466 to 468 in 6540c41