feat: Add support for sub-issue by e7217 · Pull Request #3580 · google/go-github

e7217 · 2025-05-20T15:06:58Z

Hello,
I have added some features to support Sub-issue.

The following features have been added:

Add sub-issue
Remove sub-issue
Get sub-issue list by issue
Reprioritize sub-issue

Sorry for the delay in developing this feature.
Thank you for your review😀

Fixes #3546
cc @gmlewis

codecov · 2025-05-20T15:41:38Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.32%. Comparing base (304d3d0) to head (fde3e4b).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3580      +/-   ##
==========================================
+ Coverage   91.29%   91.32%   +0.03%     
==========================================
  Files         183      184       +1     
  Lines       16087    16143      +56     
==========================================
+ Hits        14686    14742      +56     
  Misses       1227     1227              
  Partials      174      174

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gmlewis · 2025-05-20T15:43:06Z

Thank you, @e7217! Please follow the instructions in step 4 of CONTRIBUTING.md and push the changes to this PR.

gmlewis

Thank you, @e7217!
This was a quick review because that's all I currently have time for, but should help move this PR in the right direction.

github/sub_issue.go

github/sub_issue_test.go

github/sub_issue.go

Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

e7217 · 2025-05-20T17:29:50Z

Thank you, @e7217! This was a quick review because that's all I currently have time for, but should help move this PR in the right direction.

@gmlewis I appreciate your review. It has been helpful to me.

gmlewis

Thank you, @e7217!
Just a few more tweaks, and a few comments that were not addressed previously, please... then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

github/sub_issue.go

Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

e7217 · 2025-05-21T00:29:19Z

@gmlewis
Oh, it was my mistake. I'm sorry for the inconvenience. Despite that, thank you for your detailed review. I have made a commit that includes your checking points and updated the test cases.

gmlewis · 2025-05-21T12:20:27Z

github/sub_issue.go

+	// TODO: remove custom Accept header when this API fully launches.
+	req.Header.Set("Accept", mediaTypeV3)


Looking at the documentation for these endpoints, I'm not seeing any need to add the mediaTypeV3 header, so all these lines can safely be removed, I believe. Feel free to correct me if I've missed them.

Looking at the documentation for these endpoints, I'm not seeing any need to add the mediaTypeV3 header, so all these lines can safely be removed, I believe. Feel free to correct me if I've missed them.

The header values are included as shown below, and I used the predefined header values from go-github. Since the response was coming back correctly, I applied them as is. If you think it would be better to remove this, I will delete that part. Please let me know your opinion.

@gmlewis

Right, but the one you added doesn't match.

You added application/vnd.github.v3+json, so I think this one can be removed.

@gmlewis ok, I have removed it. Thank you!

gmlewis

Thank you, @e7217!
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@stevehipwell - might you have time for a code review? Thank you!

DiegoDev2

LGTM! @e7217 @gmlewis

gmlewis · 2025-05-26T19:49:05Z

Thank you, @DiegoDev2!
Merging.

e7217 added 3 commits May 19, 2025 16:34

duplicate issue

f2ab5e6

feat: support sub-issue

f45993e

Merge branch 'master' into feat/add-subissue

d310482

fix: aapply fmt and lint

a22cf85

gmlewis requested changes May 20, 2025

View reviewed changes

e7217 and others added 9 commits May 21, 2025 01:59

Update github/sub_issue.go

7c48809

Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Update github/sub_issue.go

5562069

Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Update github/sub_issue.go

42e1772

Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Update github/sub_issue.go

8c3d97c

Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Update github/sub_issue.go

36a4697

Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Update github/sub_issue.go

c090164

Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Update github/sub_issue.go

4b795b0

Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Update github/sub_issue_test.go

b04e778

Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

fix: update test case

42c6b67

gmlewis requested changes May 20, 2025

View reviewed changes

github/sub_issue.go Outdated Show resolved Hide resolved

github/sub_issue.go Outdated Show resolved Hide resolved

github/sub_issue.go Outdated Show resolved Hide resolved

github/sub_issue.go Outdated Show resolved Hide resolved

github/sub_issue.go Outdated Show resolved Hide resolved

gmlewis added the NeedsReview PR is awaiting a review before merging. label May 20, 2025

e7217 and others added 2 commits May 21, 2025 08:49

Apply suggestions from code review

7d03490

Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

fix: update test cases

d977c43

gmlewis requested changes May 21, 2025

View reviewed changes

e7217 added 2 commits May 21, 2025 14:07

fix: remove a header item

f0a4204

fix: apply lint

fde3e4b

gmlewis approved these changes May 21, 2025

View reviewed changes

DiegoDev2 approved these changes May 26, 2025

View reviewed changes

gmlewis removed the NeedsReview PR is awaiting a review before merging. label May 26, 2025

gmlewis merged commit cc0e642 into google:master May 26, 2025
7 checks passed

e7217 deleted the feat/add-subissue branch May 27, 2025 05:05

martinnormark mentioned this pull request Jun 3, 2025

Add tools for sub-issue endpoint github/github-mcp-server#470

Merged

gmlewis mentioned this pull request Jun 24, 2025

Bump version of go-github to v73.0.0 #3599

Merged

		// TODO: remove custom Accept header when this API fully launches.
		req.Header.Set("Accept", mediaTypeV3)

Conversation

e7217 commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gmlewis commented May 20, 2025

Uh oh!

gmlewis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

e7217 commented May 20, 2025

Uh oh!

gmlewis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

e7217 commented May 21, 2025

Uh oh!

gmlewis May 21, 2025

Choose a reason for hiding this comment

Uh oh!

e7217 May 21, 2025

Choose a reason for hiding this comment

Uh oh!

gmlewis May 21, 2025

Choose a reason for hiding this comment

Uh oh!

e7217 May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gmlewis left a comment

Choose a reason for hiding this comment

Uh oh!

DiegoDev2 left a comment

Choose a reason for hiding this comment

Uh oh!

gmlewis commented May 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

e7217 commented May 20, 2025 •

edited

Loading

codecov bot commented May 20, 2025 •

edited

Loading

e7217 May 21, 2025 •

edited

Loading