Skip to content

Add missing log that point to a failed Generation#98

Merged
austinvhuang merged 1 commit intogoogle:mainfrom
zeerd:patch-2
Mar 15, 2024
Merged

Add missing log that point to a failed Generation#98
austinvhuang merged 1 commit intogoogle:mainfrom
zeerd:patch-2

Conversation

@zeerd
Copy link
Contributor

@zeerd zeerd commented Mar 14, 2024

if pos >= max_tokens, the next for will not be run.

Copy link
Member

@jan-wassenberg jan-wassenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jan-wassenberg jan-wassenberg added the copybara-import Trigger Copybara for merging pull requests label Mar 14, 2024
@austinvhuang austinvhuang merged commit a2ef389 into google:main Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

copybara-import Trigger Copybara for merging pull requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants