Use bf16-rounded sqrt for scaling embeddings to match Gemma#93
Merged
copybara-service[bot] merged 1 commit intodevfrom Mar 13, 2024
Merged
Use bf16-rounded sqrt for scaling embeddings to match Gemma#93copybara-service[bot] merged 1 commit intodevfrom
copybara-service[bot] merged 1 commit intodevfrom
Conversation
copybara-service
bot
force-pushed
the
test_614903502
branch
2 times, most recently
from
9d58ebf to
26f8dfe
Compare
Thanks Daniel & Michael Han for pointing this out. https://unsloth.ai/blog/gemma-bugs PiperOrigin-RevId: 615250003
copybara-service
bot
force-pushed
the
test_614903502
branch
from
26f8dfe to
5fa2eb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use bf16-rounded sqrt for scaling embeddings to match Gemma
Thanks Daniel & Michael Han for pointing this out.
https://unsloth.ai/blog/gemma-bugs