Skip to content

Rename BUILD to BUILD.bazel. #36

Merged
dan-zheng merged 4 commits intogoogle:devfrom
dan-zheng:rename-build-bzl
Feb 24, 2024
Merged

Rename BUILD to BUILD.bazel. #36
dan-zheng merged 4 commits intogoogle:devfrom
dan-zheng:rename-build-bzl

Conversation

@dan-zheng
Copy link
Collaborator

From https://bazel.build/concepts/build-files:

Note: The BUILD file can be named either BUILD or BUILD.bazel. If both files exist, BUILD.bazel takes precedence over BUILD. For simplicity's sake, the documentation refers to these files simply as BUILD files.

This fixes an error on macOS due to build and BUILD having conflicting names.

Enable macos-latest in GitHub Actions CI, to catch these errors in the future.

This fixes an error on macOS due to `build` and `BUILD` having conflicting names.
Use matrix configuration in concurrency key.
@dan-zheng dan-zheng added the copybara-import Trigger Copybara for merging pull requests label Feb 24, 2024
@dan-zheng
Copy link
Collaborator Author

Merging since this hardens CI, which will be good for preventing further build regressions.

Also removes BUILD section that should have been stripped by Copybara.

@dan-zheng dan-zheng merged commit 3af4396 into google:dev Feb 24, 2024
@dan-zheng dan-zheng deleted the rename-build-bzl branch February 24, 2024 22:53
Copy link
Member

@jan-wassenberg jan-wassenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

copybara-service bot pushed a commit that referenced this pull request Feb 25, 2024
--
e0179ba by Dan Zheng <danielzheng@google.com>:

Rename BUILD to BUILD.bazel.

This fixes an error on macOS due to `build` and `BUILD` having conflicting names.

--
74b2707 by Dan Zheng <danielzheng@google.com>:

Enable macos-latest in GitHub Actions CI.

--
c08de58 by Dan Zheng <danielzheng@google.com>:

Fix concurrency key in GitHub Actions.

Use matrix configuration in concurrency key.

COPYBARA_INTEGRATE_REVIEW=#36 from dan-zheng:rename-build-bzl b4b978f
PiperOrigin-RevId: 610156681
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

copybara-import Trigger Copybara for merging pull requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants