Skip to content

Fix build.#35

Merged
dan-zheng merged 2 commits intogoogle:devfrom
dan-zheng:fix-includes
Feb 24, 2024
Merged

Fix build.#35
dan-zheng merged 2 commits intogoogle:devfrom
dan-zheng:fix-includes

Conversation

@dan-zheng
Copy link
Collaborator

@dan-zheng dan-zheng commented Feb 24, 2024

Fix sentencepiece include directives.

  • This was a regression introduced in e4e02a1.

Enable GitHub Actions CI for pull requests.

@dan-zheng dan-zheng changed the title Fix sentencepiece include directives. Fix build. Feb 24, 2024
@dan-zheng dan-zheng added the copybara-import Trigger Copybara for merging pull requests label Feb 24, 2024
@dan-zheng dan-zheng force-pushed the fix-includes branch 2 times, most recently from 73dec95 to e22f2e4 Compare February 24, 2024 18:53
@dan-zheng
Copy link
Collaborator Author

import/copybara check is broken but will be fixed by an in-flight internal change.

Will go ahead and merge to unblock builds.

@dan-zheng dan-zheng merged commit 4b1fa03 into google:dev Feb 24, 2024
@dan-zheng dan-zheng deleted the fix-includes branch February 24, 2024 19:03
@jan-wassenberg
Copy link
Member

Sorry to have broken the build. Thanks for fixing and adding the pull-request check :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

copybara-import Trigger Copybara for merging pull requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants