Skip the last RMSNormInplaceBatched in the Prefill phase.#268
Merged
copybara-service[bot] merged 1 commit intodevfrom Jun 21, 2024
Merged
Skip the last RMSNormInplaceBatched in the Prefill phase.#268copybara-service[bot] merged 1 commit intodevfrom
copybara-service[bot] merged 1 commit intodevfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
bot
force-pushed
the
test_645386072
branch
from
7d78639 to
7f48d7b
Compare
That only modifies activations.x, but it is called with prefill_activations which are not used after the Prefill call. PiperOrigin-RevId: 645391387
copybara-service
bot
force-pushed
the
test_645386072
branch
from
7f48d7b to
80b1347
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip the last RMSNormInplaceBatched in the Prefill phase.
That only modifies activations.x, but it is called with prefill_activations which are not used after the Prefill call.