Skip to content

Fix compilation errors in clang#267

Merged
copybara-service[bot] merged 1 commit intogoogle:devfrom
ufownl:bugfix/clang_ce
Jun 21, 2024
Merged

Fix compilation errors in clang#267
copybara-service[bot] merged 1 commit intogoogle:devfrom
ufownl:bugfix/clang_ce

Conversation

@ufownl
Copy link
Contributor

@ufownl ufownl commented Jun 21, 2024

It will occur in ubuntu-latest of GitHub Actions:

In file included from /home/runner/work/lua-cgemma/lua-cgemma/lua-cgemma/build/_deps/gemma-src/backprop/optimizer.cc:23:
/home/runner/work/lua-cgemma/lua-cgemma/lua-cgemma/build/_deps/gemma-src/./gemma/weights.h:235:57: error: unknown type name 'nullptr_t'; did you mean 'std::nullptr_t'?
  constexpr bool kHaveRaw = !hwy::IsSame<RawWeightsPtr, nullptr_t>();
                                                        ^~~~~~~~~
                                                        std::nullptr_t
/usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/x86_64-linux-gnu/c++/12/bits/c++config.h:302:29: note: 'std::nullptr_t' declared here
  typedef decltype(nullptr)     nullptr_t;
                                ^
In file included from /home/runner/work/lua-cgemma/lua-cgemma/lua-cgemma/build/_deps/gemma-src/./backprop/backward.cc:27:
In file included from /home/runner/work/lua-cgemma/lua-cgemma/lua-cgemma/build/_deps/highway-src/hwy/foreach_target.h:72:
In file included from /home/runner/work/lua-cgemma/lua-cgemma/lua-cgemma/build/_deps/gemma-src/./backprop/backward.cc:32:
/home/runner/work/lua-cgemma/lua-cgemma/lua-cgemma/build/_deps/gemma-src/./gemma/weights.h:235:57: error: unknown type name 'nullptr_t'; did you mean 'std::nullptr_t'?
  constexpr bool kHaveRaw = !hwy::IsSame<RawWeightsPtr, nullptr_t>();
                                                        ^~~~~~~~~
                                                        std::nullptr_t
/usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/x86_64-linux-gnu/c++/12/bits/c++config.h:302:29: note: 'std::nullptr_t' declared here
  typedef decltype(nullptr)     nullptr_t;
                                ^
In file included from /home/runner/work/lua-cgemma/lua-cgemma/lua-cgemma/build/_deps/gemma-src/./backprop/forward.cc:27:
In file included from /home/runner/work/lua-cgemma/lua-cgemma/lua-cgemma/build/_deps/highway-src/hwy/foreach_target.h:72:
In file included from /home/runner/work/lua-cgemma/lua-cgemma/lua-cgemma/build/_deps/gemma-src/./backprop/forward.cc:32:
/home/runner/work/lua-cgemma/lua-cgemma/lua-cgemma/build/_deps/gemma-src/./gemma/weights.h:235:57: error: unknown type name 'nullptr_t'; did you mean 'std::nullptr_t'?
  constexpr bool kHaveRaw = !hwy::IsSame<RawWeightsPtr, nullptr_t>();
                                                        ^~~~~~~~~
                                                        std::nullptr_t
/usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/x86_64-linux-gnu/c++/12/bits/c++config.h:302:29: note: 'std::nullptr_t' declared here
  typedef decltype(nullptr)     nullptr_t;
                                ^
1 error generated.
make[2]: *** [_deps/gemma-build/CMakeFiles/libgemma.dir/build.make:146: _deps/gemma-build/CMakeFiles/libgemma.dir/backprop/optimizer.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
1 error generated.
make[2]: *** [_deps/gemma-build/CMakeFiles/libgemma.dir/build.make:[118](https://github.com/ufownl/lua-cgemma/actions/runs/9608690735/job/26501927754#step:6:119): _deps/gemma-build/CMakeFiles/libgemma.dir/backprop/backward.cc.o] Error 1
1 error generated.
make[2]: *** [_deps/gemma-build/CMakeFiles/libgemma.dir/build.make:132: _deps/gemma-build/CMakeFiles/libgemma.dir/backprop/forward.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:600: _deps/gemma-build/CMakeFiles/libgemma.dir/all] Error 2
make: *** [Makefile:156: all] Error 2
Error: Process completed with exit code 2.

@ufownl
Fix compilation errors in clang
f785525 
It will occur in `ubuntu-latest` of GitHub Actions.
jan-wassenberg
jan-wassenberg approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@jan-wassenberg jan-wassenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thank you :) Strange that our internal clang accepted this.

@jan-wassenberg jan-wassenberg added the copybara-import Trigger Copybara for merging pull requests label Jun 21, 2024
@ufownl
Copy link
Contributor Author

ufownl commented Jun 21, 2024

Oops, thank you :) Strange that our internal clang accepted this.

Indeed, MacOS Clang also accepted, whether it was GitHub Actions or my own Macbook.

@copybara-service copybara-service bot merged commit c2efcb0 into google:dev Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jan-wassenberg jan-wassenberg jan-wassenberg approved these changes

Assignees

No one assigned

Labels

copybara-import Trigger Copybara for merging pull requests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ufownl @jan-wassenberg