Skip to content

Code cleanup#264

Merged
copybara-service[bot] merged 1 commit intodevfrom
test_644912543
Jun 20, 2024
Merged

Code cleanup#264
copybara-service[bot] merged 1 commit intodevfrom
test_644912543

Conversation

@copybara-service
Copy link

Code cleanup

  • Simplify template arg list, enable deduction
  • missing hn:: on " Lanes"
  • 1.0f suffix
  • move RMSNormBatched into ops.h
  • static constexpr -> constexpr
  • concrete type instead of LayerT, WeightArrayT
  • inline GetWeights
  • remove if (runtime_config.verbosity
  • merge AllocatePrefill and AllocateDecode
  • remove bf_ffw_hidden

- Simplify template arg list, enable deduction
- missing hn:: on " Lanes"
- 1.0f suffix
- move RMSNormBatched into ops.h
- static constexpr -> constexpr
- concrete type instead of LayerT, WeightArrayT
- inline GetWeights
- remove if (runtime_config.verbosity
- merge AllocatePrefill and AllocateDecode
- remove bf_ffw_hidden

PiperOrigin-RevId: 644931277
@copybara-service copybara-service bot merged commit 48ebba8 into dev Jun 20, 2024
@copybara-service copybara-service bot deleted the test_644912543 branch June 20, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant