Skip to content

Add support for custom sampling function to runtime config.#217

Merged
copybara-service[bot] merged 1 commit intogoogle:devfrom
szabadka:cross-entropy
Jun 7, 2024
Merged

Add support for custom sampling function to runtime config.#217
copybara-service[bot] merged 1 commit intogoogle:devfrom
szabadka:cross-entropy

Conversation

@szabadka
Copy link
Collaborator

@szabadka szabadka commented Jun 7, 2024

With this addition the ComputeCrossEntropy function can be moved to its own library, because now we can compute it using only the public API functions from gemma.h

With this addition the ComputeCrossEntropy function can be moved
to its own library, because now we can compute it using only the
public API functions from gemma.h
@szabadka szabadka requested a review from jan-wassenberg June 7, 2024 11:51
Copy link
Member

@jan-wassenberg jan-wassenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@jan-wassenberg jan-wassenberg added the copybara-import Trigger Copybara for merging pull requests label Jun 7, 2024
@copybara-service copybara-service bot merged commit 24db2ff into google:dev Jun 7, 2024
@szabadka szabadka deleted the cross-entropy branch June 12, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

copybara-import Trigger Copybara for merging pull requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants