Fix fix for weight type define, refs #198#216
Merged
copybara-service[bot] merged 1 commit intodevfrom Jun 7, 2024
Merged
Conversation
copybara-service
bot
force-pushed
the
test_641167995
branch
from
d783ce5 to
ac3d4c5
Compare
GEMMA_WEIGHT_T is indeed the correct flag for the C++ compiler, but the readme references CMake, and there the correct flag name is WEIGHT_TYPE. PiperOrigin-RevId: 641170380
copybara-service
bot
force-pushed
the
test_641167995
branch
from
ac3d4c5 to
e3f4374
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix fix for weight type define, refs #198
GEMMA_WEIGHT_T is indeed the correct flag for the C++ compiler,
but the readme references CMake, and there the correct flag name is WEIGHT_TYPE.