Simplifications: remove GemmaInterface and GemmaImpl#209
Merged
copybara-service[bot] merged 1 commit intodevfrom Jun 6, 2024
Merged
Simplifications: remove GemmaInterface and GemmaImpl#209copybara-service[bot] merged 1 commit intodevfrom
copybara-service[bot] merged 1 commit intodevfrom
Conversation
copybara-service
bot
force-pushed
the
test_640571115
branch
3 times, most recently
from
5bcba87 to
53b9289
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_640571115
branch
7 times, most recently
from
b3e9ea1 to
834c3ea
Compare
Split common and weights into separate lib Remove common-inl (does not have to be SIMD code), activations.cc Centralize switch(Model) to avoid duplication Move CompressWeightsT to compress_weights.cc Move LoadWeights to weights.cc PiperOrigin-RevId: 640869202
copybara-service
bot
force-pushed
the
test_640571115
branch
from
834c3ea to
57c2cd8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifications: remove GemmaInterface and GemmaImpl
Split common and weights into separate lib
Remove common-inl (does not have to be SIMD code), activations.cc
Centralize switch(Model) to avoid duplication
Move CompressWeightsT to compress_weights.cc
Move LoadWeights to weights.cc