Further improve IO, enable multiple backends without -D.#148
Merged
copybara-service[bot] merged 1 commit intodevfrom Apr 19, 2024
Merged
Further improve IO, enable multiple backends without -D.#148copybara-service[bot] merged 1 commit intodevfrom
copybara-service[bot] merged 1 commit intodevfrom
Conversation
copybara-service
bot
force-pushed
the
test_625966276
branch
8 times, most recently
from
5d0e06d to
c4107cc
Compare
copybara-service
bot
changed the title
Contributor
|
I am curious, would it be better to use the filesystem library instead of this approach ? |
Member
|
:) Yes, that has a very full-featured |
copybara-service
bot
force-pushed
the
test_625966276
branch
from
c4107cc to
ba60d10
Compare
Move Path into io.h and use for opening files. Removes dependency of gemma_lib on args. Separate Windows codepath instead of emulating POSIX functions. Plus lint fixes. PiperOrigin-RevId: 626279004
copybara-service
bot
force-pushed
the
test_625966276
branch
from
ba60d10 to
e9a0cae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further improve IO, enable multiple backends without -D.
Move Path into io.h and use for opening files.
Removes dependency of gemma_lib on args.
Separate Windows codepath instead of emulating POSIX functions.
Plus lint fixes.