Improve weight handling.#130
Merged
copybara-service[bot] merged 1 commit intogoogle:devfrom Apr 6, 2024
Merged
Conversation
Contributor
veluca93
commented
Apr 5, 2024
veluca93
commented
- Allow scaling of SFP weights
- Allow using uncompressed weights
- Do not try to compress weights in the main model calls
- Reduce code duplication in weight handling with some macros
jan-wassenberg
requested changes
Apr 5, 2024
veluca93
force-pushed
the
weight-handling
branch
from
43562c4 to
8ef7928
Compare
jan-wassenberg
requested changes
Apr 5, 2024
Member
jan-wassenberg
left a comment
jan-wassenberg
left a comment
There was a problem hiding this comment.
Just one more for do_fread :)
veluca93
force-pushed
the
weight-handling
branch
from
8ef7928 to
bcf5bf4
Compare
jan-wassenberg
added
the
copybara-import
veluca93
force-pushed
the
weight-handling
branch
2 times, most recently
from
7db0c07 to
7a72690
Compare
- Allow scaling of SFP weights - Allow using uncompressed weights - Do not try to compress weights in the main model calls - Reduce code duplication in weight handling with some macros Co-authored-by: Eugene Kliuchnikov <eustas@google.com> Co-authored-by: Thomas Fischbacher <tfish@google.com> Co-authored-by: Zoltan Szabadka <szabadka@google.com>
veluca93
force-pushed
the
weight-handling
branch
from
7a72690 to
4c23932
Compare
jan-wassenberg
approved these changes
Apr 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.