Add standalone tool to compress weights.#125
Add standalone tool to compress weights.#125copybara-service[bot] merged 1 commit intogoogle:devfrom
Conversation
jan-wassenberg
left a comment
jan-wassenberg
left a comment
There was a problem hiding this comment.
Thanks for adding this standalone util :)
gemma.cc
Outdated
There was a problem hiding this comment.
Right above this we have a GetCompressedWeightsT, can't we use that?
There was a problem hiding this comment.
I wanted to add a separate function, because I think the functionality to fall back to uncompressed weights should be removed from GetCompressedWeights, and the --weights flag should be deprecated in gemma and work only in this separate tool. This should not be a problem since I could not find any working uncompressed weights file anywhere.
There was a problem hiding this comment.
Ah, I see. Yes, agree we can remove the --weights soon. It's possibly useful still during the short term for Phil's export script, which does produce uncompressed weights.
|
Very cool I was thinking that it would be nice to have this separated out as its own tool. This might be a good candidate code to have in the |
Co-authored-by: Eugene Kliuchnikov <eustas@google.com>
jan-wassenberg
left a comment
jan-wassenberg
left a comment
There was a problem hiding this comment.
Thanks for making the change!
jan-wassenberg
added
the
copybara-import
3 participants
No description provided.