Fix compilation error when HWY_COMPILER_GCC_ACTUAL < 1300#120
Merged
copybara-service[bot] merged 1 commit intogoogle:devfrom Mar 28, 2024
Merged
Conversation
Contributor
|
Thanks, maybe related - |
jan-wassenberg
approved these changes
Mar 28, 2024
Member
jan-wassenberg
left a comment
There was a problem hiding this comment.
Nice solution, thank you for fixing this :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue is caused by
hwy::ConvertScalarTocalled inEmbeddingScaling. The comment onEmbeddingScalingsaid that it's for rounding the float to bf16 to match Gemma's Embedder. It calls this version of the template function:When
HWY_COMPILER_GCC_ACTUAL < 1300and there is no built-in function__builtin_bit_cast, It will not beconstexpr. However,constexprattribute ofEmbeddingScalingonly followsSqrt, which may cause compilation errors. So I open this PR to fix it.