This repository was archived by the owner on Aug 5, 2024. It is now read-only.
Provide an alternative to style injection for CSP purposes#88
Open
adcoelho wants to merge 2 commits intogoogle:masterfrom
Open
Provide an alternative to style injection for CSP purposes#88adcoelho wants to merge 2 commits intogoogle:masterfrom
adcoelho wants to merge 2 commits intogoogle:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Author
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have run into a problem when trying to introduce Content Security Policy (CSP) in my project where, by default, the Diff Match Patch javascript library injects CSS directly into the DOM.
For webpages secured using CSP, this requires to allow style-src 'unsafe-inline' which kind of defeats the purpose of having such policy.
With this PR we will provide an alternative for stricter CSP environments.
The style injection can now be turned off with:
and the following CSS file needs to be manually added to the webpage:
If merged, I can then update the Javascript portion of the wiki with relevant instructions.