Conversation
-- 284576129: BEGIN_PUBLIC Define an abstract class for Activation. This would be used by a Wasm context to implement FindValue, as opposed to maintaining an embedded Activation. Values have unmanaged lifetimes, meaning if it difficult to add/remove values from an Activation repeatedly. END_PUBLIC -- 284290583: Migrate existing users of the tools/build_defs/golden_test macros to use the new macro location. This CL is supposed to be a no-op, and https://paste.googleplex.com/5747263567560704?raw shows it will be. If I've messed up, or e.g. an intervening depot CL means something unexpected happens, that's fine; please fix-forward. This CL is #2 out of 3 in http://b/145011071#comment2. Tested: TAP --sample ran all affected tests and none failed http://test/OCL:283986728:BASE:284250161:1575670327474:2f203dc8 -- 284044257: BEGIN_PUBLIC Fix parsing bug with raw strings (e.g. r""). Switch conformance tests to use C++ parser instead of Go parser. END_PUBLIC PiperOrigin-RevId: 284576129
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
2 participants
284576129:
BEGIN_PUBLIC
Define an abstract class for Activation.
This would be used by a Wasm context to implement FindValue, as opposed
to maintaining an embedded Activation. Values have unmanaged lifetimes,
meaning if it difficult to add/remove values from an Activation repeatedly.
END_PUBLIC
284290583:
Migrate existing users of the tools/build_defs/golden_test macros to use the new macro location.
284044257:
BEGIN_PUBLIC
Fix parsing bug with raw strings (e.g. r"").
Switch conformance tests to use C++ parser instead of Go parser.
END_PUBLIC
PiperOrigin-RevId: 284576129
Fixes #28