fixing compilation issues: clang, c++23#1764
Merged
copybara-service[bot] merged 1 commit intogoogle:masterfrom Oct 28, 2025
bomkvilt:outline-declarations
Merged
fixing compilation issues: clang, c++23#1764copybara-service[bot] merged 1 commit intogoogle:masterfrom bomkvilt:outline-declarations
copybara-service[bot] merged 1 commit intogoogle:masterfrom
bomkvilt:outline-declarations
Conversation
Collaborator
|
/gcbrun |
Contributor
Author
|
@jnthntatum and can you tell, please, when to expect a next release incorporating this patch? |
Collaborator
|
Let me ask and get back to you. Internally, we just always build at head so tagging a release doesn't affect us much. We've historically just added new releases on request from partners. We should probably set up a regular cadence. |
Collaborator
|
I'll tag a release this week and get it published on BCR. Next year we'll try to setup a more regular quarterly release. |
Contributor
Author
|
Thankyou!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves class methods, that use incomplete type, placing them after the point where those types are fully defined