Avoid nesting status macros#1450
Merged
copybara-service[bot] merged 1 commit intomasterfrom May 2, 2025
unknown repository
Merged
Avoid nesting status macros#1450copybara-service[bot] merged 1 commit intomasterfrom unknown repository
copybara-service[bot] merged 1 commit intomasterfrom
unknown repository
Conversation
In MSVC, when there are nested macro invocations, the value of __LINE__ will be the same across the nested invocations. This causes temporaries from multiple nested invocations of CEL_ASSIGN_OR_RETURN to conflict with each-other. Thankfully, this issue seems to only occur in one place in the entire codebase, and it probably won't recur too often.
jnthntatum
approved these changes
May 2, 2025
ghost
deleted the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In MSVC, when there are nested macro invocations, the value of LINE will be the same across the nested invocations. This causes temporaries from multiple nested invocations of CEL_ASSIGN_OR_RETURN to conflict with each-other.
Thankfully, this issue seems to only occur in one place in the entire codebase, and it probably won't recur too often.
Related issue: #768