cel_cc_embed: Open in file in binary mode#1443
Merged
copybara-service[bot] merged 1 commit intomasterfrom May 2, 2025
unknown repository
Merged
cel_cc_embed: Open in file in binary mode#1443copybara-service[bot] merged 1 commit intomasterfrom unknown repository
copybara-service[bot] merged 1 commit intomasterfrom
unknown repository
Conversation
jnthntatum
approved these changes
May 2, 2025
Collaborator
jnthntatum
left a comment
jnthntatum
left a comment
There was a problem hiding this comment.
This is reasonable -- we will still have to apply the change internally and export, but I think we can make copybara a bit better about reporting you as the original author. No action needed on your part right now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary on Windows; otherwise, newline conversion will corrupt the result.
Related issue: #768