Add AddUnknownPattern() and AddMissingPattern().#1442
Merged
copybara-service[bot] merged 1 commit intomasterfrom Apr 17, 2025
Merged
Add AddUnknownPattern() and AddMissingPattern().#1442copybara-service[bot] merged 1 commit intomasterfrom
copybara-service[bot] merged 1 commit intomasterfrom
Conversation
copybara-service
bot
force-pushed
the
test_748615528
branch
from
da87fc7 to
9356b63
Compare
The other activation functions can be used incrementally, but SetUnknownPatterns() and SetMissingPatterns() cannot. This makes it a bit annoying to use, since you can't have a wrapper function that either binds an attribute or add an unknown pattern, that you could for example call in a loop. Since attribute patterns are just a vector anyway, it is easy to make it support incremental additions. PiperOrigin-RevId: 748766532
copybara-service
bot
force-pushed
the
test_748615528
branch
from
9356b63 to
050b21e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add AddUnknownPattern() and AddMissingPattern().
The other activation functions can be used incrementally, but SetUnknownPatterns() and SetMissingPatterns() cannot. This makes it a bit annoying to use, since you can't have a wrapper function that either binds an attribute or add an unknown pattern, that you could for example call in a loop.
Since attribute patterns are just a vector anyway, it is easy to make it support incremental additions.