fix(live): history_config rejection on Vertex/Enterprise Live sessions#6035
Open
allen-stephen wants to merge 3 commits into
Open
fix(live): history_config rejection on Vertex/Enterprise Live sessions#6035allen-stephen wants to merge 3 commits into
allen-stephen wants to merge 3 commits into
Conversation
Collaborator
|
I have completed the read-only triage and architectural analysis of Pull Request #6035. The Google CLA signature is verified successfully, and all background tests run clean. I have generated a premium, detailed analysis of the changes, their justification, and alignment with ADK's design patterns. Please find the complete review here: Key Highlights & Recommendation:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
Problem:
On the Vertex AI / Gemini Enterprise Agent Platform backend, ADK auto-injects
history_configinto the Live setup message when seeding conversation history. That backend has nohistory_configfield and rejects it withValueError: history_config parameter is only supported in Gemini Developer API mode, not in Gemini Enterprise Agent Platform modeSolution:
Gate the history_config auto-injection to the Gemini Developer API backend only (
isinstance(llm, Gemini)andllm._api_backend == GoogleLLMVariant.GEMINI_API). On Vertex, history is already seeded via the sanctionedsend_history(send_client_content) path.Testing Plan
Unit Tests:
$ pytest tests/unittests/flows/llm_flows/test_base_llm_flow.py -k history_config
2 passed, 35 deselected, 4 warnings in 0.78s
Manual End-to-End (E2E) Tests:
Verified intended functionality in ADK web.
Checklist
Additional context
N/A