Skip to content

fix(deps): bump starlette and fastapi to address CVE-2026-48710#5894

Closed
luis5tb wants to merge 2 commits into
google:mainfrom
luis5tb:worktree-CVE-2026-48710
Closed

fix(deps): bump starlette and fastapi to address CVE-2026-48710#5894
luis5tb wants to merge 2 commits into
google:mainfrom
luis5tb:worktree-CVE-2026-48710

Conversation

@luis5tb

@luis5tb luis5tb commented May 29, 2026

Copy link
Copy Markdown
Contributor

Starlette prior to 1.0.1 did not validate the HTTP Host header before reconstructing request.url, allowing a malformed header to bypass security restrictions based on request.url.path. Bump starlette to >=1.0.1 and fastapi to >=0.133.0 (the minimum version compatible with starlette >=1.0.1).

Closes: #5893

Testing Plan

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.
= 6750 passed, 17 skipped, 31 xfailed, 9 xpassed, 2997 warnings in 228.90s (0:03:48) =

No new tests required — this is a dependency version bump only. All existing unit tests pass (0 failures) with the updated starlette (1.2.0) and fastapi (0.136.3). The 31 xfailed and 9 xpassed are pre-existing @pytest.mark.xfail tests unrelated to this change.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

@google-cla

google-cla Bot commented May 29, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@adk-bot adk-bot added the web [Component] This issue will be transferred to adk-web label May 29, 2026
Starlette prior to 1.0.1 did not validate the HTTP Host header before
reconstructing request.url, allowing a malformed header to bypass
security restrictions based on request.url.path. Bump starlette to
>=1.0.1 and fastapi to >=0.133.0 (the minimum version compatible with
starlette >=1.0.1).

Fixes google#5893
@luis5tb luis5tb force-pushed the worktree-CVE-2026-48710 branch from cc3992f to 363a8d9 Compare May 29, 2026 09:36
@rohityan rohityan self-assigned this May 29, 2026
@rohityan rohityan added the request clarification [Status] The maintainer need clarification or more information from the author label May 29, 2026
@rohityan

Copy link
Copy Markdown
Collaborator

Hi @luis5tb , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Can you please fix the formatting errors.

@boyangsvl boyangsvl self-assigned this May 29, 2026
copybara-service Bot pushed a commit that referenced this pull request May 29, 2026
Starlette prior to 1.0.1 did not validate the HTTP Host header before
reconstructing request.url, allowing a malformed header to bypass
security restrictions based on request.url.path. Bump starlette to
>=1.0.1 and fastapi to >=0.133.0 (the minimum version compatible with
starlette >=1.0.1).

Fixes #5893

Merge #5894

Change-Id: If7743e53d95740452c9e562e9bba98d132ae049e
@adk-bot

adk-bot commented May 29, 2026

Copy link
Copy Markdown
Collaborator

Thank you @luis5tb for your contribution! 🎉

Your changes have been successfully imported and merged via Copybara in commit 81add39.

Closing this PR as the changes are now in the main branch.

@adk-bot adk-bot added the merged [Status] This PR is merged label May 29, 2026
@adk-bot adk-bot closed this May 29, 2026
settler-av pushed a commit to settler-av/adk-python that referenced this pull request Jun 1, 2026
Starlette prior to 1.0.1 did not validate the HTTP Host header before
reconstructing request.url, allowing a malformed header to bypass
security restrictions based on request.url.path. Bump starlette to
>=1.0.1 and fastapi to >=0.133.0 (the minimum version compatible with
starlette >=1.0.1).

Fixes google#5893

Merge google#5894

Change-Id: If7743e53d95740452c9e562e9bba98d132ae049e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged [Status] This PR is merged request clarification [Status] The maintainer need clarification or more information from the author web [Component] This issue will be transferred to adk-web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix to update Starlette vulnerability [HIGH] CVE-2026-48710 - Host Header Validation Bypass

4 participants