chore: Restore .vscode/settings.json, and document why#483
chore: Restore .vscode/settings.json, and document why#483vorburger wants to merge 1 commit intogoogle:mainfrom
Conversation
Summary of ChangesHello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request reintroduces the project's required Visual Studio Code settings by renaming the recommended settings file and removing it from Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request restores the .vscode/settings.json file to the repository, removes it from .gitignore, and adds documentation to CONTRIBUTING.md explaining the rationale. The goal is to ensure a consistent development environment that aligns with the project's formatting standards. The changes are logical and well-explained. I have one suggestion to improve the clarity and platform-agnosticism of the new documentation.
45295d6 to
362621e
Compare
|
Each developer has their own setup, checking in this would cause headache. It's also not a good practice to checkin settings.json. We can have a recommended settings on the side as newcomers' starting point. |
@Jacksunwei may I respectfully but fundamentally disagree with you about this? Check out the addition to the What you mean is that one may also have OTHER (!) VS Code settings which are your "personal preferences" instead of "project requirements". And I totally agree with you about that! But that's something else. Those belong into personal settings in your VS Code User Settings instead. The location of this file varies by platform (e.g., I hope that this additional context that I've hereby provided helps you to see why this makes sense and is required? |
This restores #366 which was reverted in #471.
It documents why.