fix(core): retry invalid structured model responses - #1433
Open
BlueCatPro wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
1. Link to an existing issue:
Problem:
When
set_model_responsearguments fail output-schema validation, the validation exception prevents the model from receiving actionable feedback and retrying with a corrected structured response.Solution:
set_model_responseso the model can retry.EventActions.Testing Plan
Unit Tests:
Tests executed:
EventActionsTestOutputSchemaTestSetModelResponseToolTestResult:
BUILD SUCCESSManual End-to-End (E2E) Tests:
Not run against a live model. A Runner-level regression test using the scripted
TestLlmverifies that validation feedback from the invalid call is included in the retry request and that only the corrected, validated response becomes the final structured output.Checklist
CONTRIBUTING.mddocument.Additional context
This is my first open-source contribution and my first contribution to adk-java. I may have missed some repository conventions, so I would appreciate any guidance and am happy to make follow-up changes. Thank you for your time and review!