Skip to content

Conversation

@KPJoshi
Copy link

@KPJoshi KPJoshi commented Nov 4, 2025

This commit adds documentation for the User Simulation feature in ADK, which is already available but currently undocumented.

Tested locally using mkdocs serve.

Copy link
Collaborator

@joefernandez joefernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for this!

```json
{
"criteria": {
# same as before
Copy link
Collaborator

@koverholt koverholt Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to make one quick callout that JSON doesn't support comments, and so this line renders the JSON as invalid - suggest removing this line. Otherwise thanks for the PR on this awesome new feature!

Copy link
Author

@KPJoshi KPJoshi Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this for compactness but I can restore it to be same as before. Alternatively I can reduce line count a bit by inlining some of the braces. WDYT?
Personally I'm fine with it as it is. The focus is the user sim config and copying the criteria is easy.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Since it's less than 10 additional lines to include, I would suggest including the full code. Otherwise users might get JSON errors if they try to copy/paste that EvalConfig as-is. But I don't consider it a blocking issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants