Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24195 +/- ##
=======================================
Coverage 74.02% 74.02%
=======================================
Files 1095 1095
Lines 103532 103532
Branches 3079 3079
=======================================
+ Hits 76638 76644 +6
+ Misses 26526 26520 -6
Partials 368 368
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
bupd
added
the
release-note/ignore-for-release
Add benchmarks for the rbac evaluator on project roles: allowed, denied, many projects and a public project. The existing project evaluator benchmarks now fail if the permission is denied, so they can't silently measure the deny path. Add a test that a project member cannot reach another project's resources through '..' segments. Signed-off-by: Prasanth Baskar <prasanth@8gears.com>
bupd
force-pushed
the
project-role-tests
branch
from
October 21, 2026 12:11
216285f to
e485cde
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only, split out of #24029. No production code changes.
benchmark_test.go: benchmarks for the rbac evaluator on project roles (allowed, denied, 10k projects, public project), so changes to permission evaluation can be measured.BenchmarkProjectEvaluatorandBenchmarkProjectEvaluatorParallelnow fail if the permission is denied. Before, a broken setup would quietly benchmark the deny path.TestTraversalDoesNotReachAnotherProject: a project admin of project 1 cannot reach project 2 through..segments in the resource path.Run with
go test -run . -bench . ./common/rbac/project/.