-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Update OpenXR Settings page for 4.6 #11546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| Spatial Entity | ||
| ~~~~~~~~~~~~~~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Spatial Entity | |
| ~~~~~~~~~~~~~~ | |
| Spatial Entities | |
| ~~~~~~~~~~~~~~~~ |
How it's usually called
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it's inconsistent with other places, the documentation uses "spatial entities", the settings also says "render model" but the entry here and the associated page says "render models", it's weird to me that the section "Spatial Entity" links to the page "spatial entities", also the OpenXR extension name is "spatial entities" not "spatial entity"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BastiaanOlij is the actual name of the extension the plural version or the singluar version? Because the Kronos website blog uses plural, but then the spec sheet uses singular (here)
|
Made suggested changes except for the Spatial Entity subsection name change. |
| Spatial Entity | ||
| ~~~~~~~~~~~~~~ | ||
|
|
||
| This extension and its settings are used to obtain and interacting with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| This extension and its settings are used to obtain and interacting with | |
| This extension and its settings are used to obtain and interact with |

Does what the title says. Images have been updated, and information on the Frame Synthesis and Spatial Entity extensions have been added. Descriptions are basically taken word for word from the PRs that added them.
Frame Synthesis PR: godotengine/godot#109803
Spatial Entities PR: godotengine/godot#107391