Refresh core_types.rst to remove outdated and redundant information. #11439
+19
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivorforce
added
enhancement
area:engine details
I've seen a few examples out there but I agree it's very uncommon now, so it's safe to remove. |
Calinou
reviewed
Nov 4, 2025
Comment on lines
+44
to
+46
| ``memnew``/``memdelete`` also use a little C++ magic to automatically call post-init | ||
| and pre-release functions, for example to notify Objects right after they are created, | ||
| and right before they are deleted. |
There was a problem hiding this comment.
Suggested change
| ``memnew``/``memdelete`` also use a little C++ magic to automatically call post-init | |
| and pre-release functions, for example to notify Objects right after they are created, | |
| and right before they are deleted. | |
| ``memnew``/``memdelete`` also use a little C++ magic to automatically call post-init | |
| and pre-release functions. For example, this is used to notify Objects right after they are created, | |
| and right before they are deleted. |
Calinou
reviewed
Nov 4, 2025
Comment on lines
+156
to
+157
| None of Godot's containers are thread-safe. When you expect multiple threads to access them, you must use multithread | ||
| protections, like ``Mutex`` or ``Semaphore``. |
There was a problem hiding this comment.
Suggested change
| None of Godot's containers are thread-safe. When you expect multiple threads to access them, you must use multithread | |
| protections, like ``Mutex`` or ``Semaphore``. | |
| None of Godot's containers are thread-safe. When you expect multiple threads to access them, you must use multithread | |
| protections, like :ref:`class_mutex` or :ref:`class_semaphore`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The page currently contains quite a lot of outdated, redundant, or unnecessary information.
In the interest of streamlining what is needed, I'm proposing to remove these parts:
Definitions
uint32_t.int) or platform independent (e.g.uint32_t) types. Our stance towards this has changed, and we now prefer platform independent types. Anyway, recommendations are better saved for the contributing docs, so this should be removed.size_tis always 64 bit is plain wrong, it's 32-bit in 32-bit binaries.CharTypeno longer exists,wchar_tis used.Memory Model
While a nice read, I don't think this text is needed. There are no practical take-aways from this section. Some of the claims are now wrong or misleading. For example, Godot's types are not always minimal —
Objecttypes are unexpectedly large, and they are some of Godot's most common types.The part about allocation and segmentation details has unbacked claims. Since the text was written (earlier than 2015), allocators and memory management have changed. Besides, I've seen reports of modern C++ projects that changed significantly in RAM use when using different allocators, due to fragmentation. It is not relevant to document this, and new users of the engine do not need to read this.
The final part with memory pools is no longer relevant (or at least, no longer nearly as relevant). Since 4.0, memory pool containers have been removed. Only some memory pools are now used in the engine, most private to specific classes.
Allocating memory