Update the Object class engine details page. #11438
Open
+135
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivorforce
added
enhancement
area:engine details
Ivorforce
force-pushed
the
object-semantics
branch
3 times, most recently
from
b0984d7 to
4617315
Compare
|
|
||
| You should also never store ``RefCounted`` subclasses using raw pointers, for example | ||
| ``RefCounted *object = memnew(RefCounted)``. This is unsafe because other owners may destruct the object, leaving you | ||
| with a dangling pointer, which will eventually result in a crash. |
There was a problem hiding this comment.
A bit of repetition here with "will eventually result in a crash"
There was a problem hiding this comment.
It's in both sections, yes. But people may not read both.
Do you think we should rephrase one?
There was a problem hiding this comment.
I think a bit of a rephrase would be the best option
Ivorforce
force-pushed
the
object-semantics
branch
from
4617315 to
bb63b9c
Compare
Calinou
reviewed
Nov 4, 2025
| } | ||
| If the cast fails, ``nullptr`` is returned. This works the same as ``dynamic_cast``, but does not use | ||
| `C++ .RTTI <https://en.wikipedia.org/wiki/Run-time_type_information>`__. |
There was a problem hiding this comment.
@copilot
Suggested change
| `C++ .RTTI <https://en.wikipedia.org/wiki/Run-time_type_information>`__. | |
| `C++ RTTI <https://en.wikipedia.org/wiki/Run-time_type_information>`__. |
Calinou
reviewed
Nov 4, 2025
Comment on lines
+342
to
+344
| All objects in Godot have a :ref:`_notification <class_Object_private_method__notification>` | ||
| method that allows it to respond to engine level callbacks that may relate to it. | ||
| More information can be found on the :ref:`doc_godot_notifications` page. |
There was a problem hiding this comment.
Suggested change
| All objects in Godot have a :ref:`_notification <class_Object_private_method__notification>` | |
| method that allows it to respond to engine level callbacks that may relate to it. | |
| More information can be found on the :ref:`doc_godot_notifications` page. | |
| All objects in Godot have a :ref:`_notification <class_Object_private_method__notification>` | |
| method that allows it to respond to engine-level callbacks that may relate to it. | |
| More information can be found on the :ref:`doc_godot_notifications` page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refreshes some outdated information, and adds a few missing bits and pieces:
GDREGISTER_CLASSinstead ofClassDB::register_class(which is no longer recommended)Object ownership and castingheading, where the different ownership models are explained.