Update SConstruct and .gdextension file of the godot-cpp example with newest conventions
#11405
+34
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivorforce
force-pushed
the
godot-cpp-example-sconstruct
branch
from
47c8295 to
edf4390
Compare
paddy-exe
approved these changes
Oct 23, 2025
Ivorforce
force-pushed
the
godot-cpp-example-sconstruct
branch
from
edf4390 to
bf09cfd
Compare
AThousandShips
approved these changes
Oct 24, 2025
mhilbrunner
approved these changes
Nov 5, 2025
|
@Ivorforce Afraid this needs a rebase, but otherwise looks good to go for me :) |
…with newest conventions. # Conflicts: # tutorials/scripting/cpp/gdextension_cpp_example.rst
Ivorforce
force-pushed
the
godot-cpp-example-sconstruct
branch
from
bf09cfd to
c46a399
Compare
|
Looks like #11381 broke the example since the example |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes:
SConstructfile currently lists properties. I don't think this is very useful, because a non-SCons user will not understand how to use this information anyway. Instead, I add a link to the SCons docs.SConstructfile..frameworklogic fromSConstructand.gdextensionfile. We've figured some months that this wasn't needed (matching godot-cpp-template)SHLIBPREFIXalong withSHLIBSUFFIX, to removelibprefix from DLL files (matching godot-cpp-template)..gdextensionfiles. This makes it possible to rename the folders they are in, leading to fewer problems. It also solves an unfixed hot reload problem on macOS.dependenciessection since it's no longer necessary, add a link to the.gdextensionfile docs instead.