-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Document relative paths in .gdextension files being supported
#11381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document relative paths in .gdextension files being supported
#11381
Conversation
5ccec64 to
78747d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to switch the example to use relative names.
We discussed this in GDExtension meetings before, and concluded (iirc) that relative paths are preferable since this supports moving around and renaming the gdextension without having to worry about the .gdextension file. This is also the reason we changed it in the template.
I don't think there are any advantages to using absolute paths, so I'm not sure I'd even mention them.
78747d7 to
72fcb7b
Compare
Done. |
72fcb7b to
c0ebfbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍🏻
c0ebfbc to
386c79f
Compare
- Mention support for comments in `.gdextension` files. - List recommended import options for GDExtension icons.
386c79f to
9420053
Compare
|
Thanks! Merged. |
.gdextensionfiles.